Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web Frameworks Benchmark Performance #529

Open
panesofglass opened this issue Nov 22, 2022 · 3 comments
Open

Web Frameworks Benchmark Performance #529

panesofglass opened this issue Nov 22, 2022 · 3 comments

Comments

@panesofglass
Copy link

I must have done something wrong while setting up the Giraffe application for the Web Frameworks Benchmark. I would expect to see both giraffe and giraffe-endpoints closer to the top. The source code is here. I'd be interested to learn what I did wrong, as this looks to me like a pretty straightforward Giraffe setup, and it resembles what I use in production applications. If I'm doing something wrong, I'd love to know! Thanks!
@SIRHAMY
Copy link
Contributor

SIRHAMY commented Nov 25, 2022

Was curious about this as well.

Does it need to be Giraffe 6?

@SIRHAMY SIRHAMY mentioned this issue Dec 6, 2022
Merged
@SIRHAMY
Copy link
Contributor

SIRHAMY commented Dec 6, 2022

I believe this PR will get the giraffe benchmarks in functional parity with the other dotnet (fsharp, csharp) benchmarks so should get more accurate readings with it.

@SIRHAMY
Copy link
Contributor

SIRHAMY commented Jan 4, 2023

This should be resolved now
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@panesofglass @SIRHAMY