A2-7-3: missing documentation when there's a comment after doxygen grouping

[fjatWbyT]

Affected rules

• A2-7-3

Description

It appears that adding a comment after the closing characters of a member grouping triggers alerts for the methods inside.

Example

/// @brief Member group b.
struct memgrpb {
  /// @brief Group with comment at the end.
  ///@{
  void memgrpb_func0();
  void memgrpb_func1();
  ///@} End of group
};

/// @brief Member group d.
struct memgrpd {
  /// @brief Group without comment at the end.
  ///@{
  void memgrpd_func0();
  void memgrpd_func1();
  ///@}
};

memgrpb_func1 and memgrpb_func0 are evaluated with missing documentation (in contrast with the functions in memgrpd) on query cpp/autosar/src/rules/A2-7-3/UndocumentedUserDefinedType.ql.

Related to #391.

[lcartey]

The patterns on these lines need to be expanded to support different form of group close:

codeql-coding-standards/cpp/autosar/src/rules/A2-7-3/UndocumentedUserDefinedType.ql

Lines 29 to 31 in 18a3f35

	opening = true and result = ["///@{", "/**@{*/"]
	or
	opening = false and result = ["///@}", "/**@}*/"]

At the moment this uses the simple matches(...) predicate, but we may need to move to regular expressions to catch more cases.