Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: do not convert operators to lower case #3

Open
elrayle opened this issue Sep 5, 2022 · 1 comment
Open

REFACTOR: do not convert operators to lower case #3

elrayle opened this issue Sep 5, 2022 · 1 comment
Labels
refactor Request to refactor to improve code or reduce technical debt.

Comments

@elrayle
Copy link
Collaborator

elrayle commented Sep 5, 2022

The original javascript converted incoming operators (e.g. AND) to lower case (e.g. and) during the tokenization process. The initial translation stayed as close to the original javascript as possible and reasonable with assumptions that a later process would require the output to be in the format created in the javascript.

I do not see the need for this case conversion in later processing. Recommending a refactor to not convert operators case.

@elrayle elrayle added the refactor Request to refactor to improve code or reduce technical debt. label Oct 25, 2022
@elrayle
Copy link
Collaborator Author

elrayle commented Oct 25, 2022

Is there an advantage to requiring a specific case? Consider making the parser case-insensitive for operators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Request to refactor to improve code or reduce technical debt.
Projects
None yet
Development

No branches or pull requests

1 participant