Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default values for the ConfigAuth resource #461

Open
tschlaepfer opened this issue Aug 6, 2024 · 1 comment
Open

Remove default values for the ConfigAuth resource #461

tschlaepfer opened this issue Aug 6, 2024 · 1 comment

Comments

@tschlaepfer
Copy link

tschlaepfer commented Aug 6, 2024

The provider specifies default values for, ldap_group_membership, ldap_group_scope, and ldap_scope in the ConfigAuth resource.

Can they be removed? or is there a specific reason why they are being defined?

While they may not cause any issues when using Terraform (I have not tested this), they cause the Crossplane Harbor provider to fail, see globallogicuki/provider-harbor#3. The Crossplane provider for Harbor is built based on this Terraform provider using the upjet tool from Upbound.

@flbla
Copy link
Contributor

flbla commented Aug 16, 2024

Hi,
If we remove those default values, it will need some more work
without them, terraform will still try to delete them, but since they are default values ​​in harbor, harbor won't delete them:

      - ldap_group_membership = "memberof" -> null
      - ldap_group_scope      = "base" -> null
      - ldap_scope            = "base" -> null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants