New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a demo #433

Open

RoneoOrg opened this issue Jun 28, 2022 · 1 comment

Collaborator

RoneoOrg commented Jun 28, 2022

No description provided.

RoneoOrg self-assigned this

Collaborator Author

RoneoOrg commented Jun 28, 2022

Done, a demo is available here: https://hugo-theme-beautifulhugo.netlify.app/

But:

The Photoswipe gallery thumbnails are not shown without hardcoding baseUrl in config.toml

Details:

see how the thumbnails are broken in this deploy
after hardcoding baseUrl (commit 8d21174b), thumbs are fine. Note that deploys of the demo site are handled by Netlify following this hugo command: cd exampleSite && hugo --gc --themesDir ../..

This needs improvement: thumbs should be displayed without hardcoding baseUrl, as it breaks the "One-click deploy" to Netlify feature.

I'm not familiar with Hugo baseUrl handling, help welcome!

RoneoOrg removed their assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment