Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate self-signed HTTPS #78

Open
SamJakob opened this issue Nov 2, 2023 · 3 comments
Open

Investigate self-signed HTTPS #78

SamJakob opened this issue Nov 2, 2023 · 3 comments
Assignees
Labels
discussion enhancement New feature or request

Comments

@SamJakob
Copy link
Contributor

SamJakob commented Nov 2, 2023

It would seem (according to an email report) that upstream self-signed certificates do not work, this needs to be checked.

Then, we need to figure out whether self-signed or invalid certificates should be allowed by default. I don’t see a security risk from doing that but it might make debugging harder or more confusing because we would bypass those issues.

I’m thinking the best option is to add it behind a flag.

@SamJakob SamJakob added enhancement New feature or request discussion labels Nov 2, 2023
@SamJakob SamJakob self-assigned this Nov 2, 2023
@r-brown
Copy link

r-brown commented Mar 18, 2024

I'd support adding an additional configuration option to allow self-signed certs.

@ispy1
Copy link

ispy1 commented Mar 28, 2024

I skipped checking the certificate where the code creates http.client and it works fine now

	tr := &http.Transport{
		TLSClientConfig: &tls.Config{
			InsecureSkipVerify: true,
		},
	}

	// 创建一个基于自定义Transport的HTTP客户端
	client := &http.Client{
		Transport: tr,
	}

@seungick
Copy link

seungick commented Apr 1, 2024

I created a patch file for the issue. The approach is same with @ispy1. :)
you can refer below link.

hoppscotch/hoppscotch#882 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants