Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Dependencies #180

Open
2 tasks
xavez opened this issue Jul 13, 2016 · 17 comments
Open
2 tasks

Simplify Dependencies #180

xavez opened this issue Jul 13, 2016 · 17 comments

Comments

@xavez
Copy link
Member

xavez commented Jul 13, 2016

I couldn’t get it to run locally yet, but I can already see we can probably simplify a lot of dependencies:

  • Get rid of the ruby dependency by switching sass and compass to node-sass
  • Get rid of the bower dependency by installing all necessary packages via npm

Unfortunately, I cannot code & test it, since nothing works for me yet, otherwise, I’d have made a PR ;).

@Tjoosten
Copy link
Contributor

I assign myself to it.

To @pietercolpaert I got almost a pr ready for this one.

@xavez
Copy link
Member Author

xavez commented Jul 14, 2016

@Tjoosten great!

@pietercolpaert
Copy link
Member

@Tjoosten Sounds great! You're working on making hyperRail work with gulp instead of grunt, right?

@Tjoosten
Copy link
Contributor

@pietercolpaert Yes slowly I will demolish grunt and replace it wilt Laravel Elixir that is based on the GulpJs systems

@xavez
Copy link
Member Author

xavez commented Jul 15, 2016

@Tjoosten if you need a good example to start with, check out the gulp workflow here: https://github.com/getchopstick/chopstick-boilerplate/blob/master/gulpfile.js or here: https://github.com/mono-company/bedrock/blob/master/gulpfile.js. Not 100% relevant but architecturally a good example.

@Tjoosten
Copy link
Contributor

@xavez i'm using the default laravel-elixir system for this.

@pietercolpaert can u describe the asset files. What is included in what asset file. Because it's a horrible experience for me reading these grunt files.

@pietercolpaert
Copy link
Member

@Tjoosten Sorry, I cannot help here. Maybe @bramdevries can?

@pietercolpaert
Copy link
Member

@Tjoosten Any update? Are you going to be able to PR this or should someone else do this?

@Haroenv
Copy link
Member

Haroenv commented Aug 14, 2016

Maybe open a PR with the work already done so there can be collaboration? There are quite a bit of dependencies right now.

@Tjoosten
Copy link
Contributor

Will do it later in the night if you don't mind

@Haroenv
Copy link
Member

Haroenv commented Aug 14, 2016

Sure, I don't mind

@AdriVanHoudt
Copy link

I wanted to tackle this (together with updating to a newer angular version and maybe look into other optimizations) but I couldn't get the server running, I have php but the composer thing just didn't work. Is there maybe a possibility to either help me or change that to make it easier to get started?

@Bertware
Copy link
Member

Bertware commented Oct 21, 2017

What server are you trying to get running, or where are you stuck?
Setting this project up is a pain, from the top of my head you need npm, compass, grunt and bower installed. I'll see if I can reduce the dependencies a bit next week if I have the time, wasn't aware of this issue.

@pietercolpaert
Copy link
Member

I just tried to run it from scratch. You do not really need to bower and grunt. These were the steps taken:
(mind that you also now need php-intl, composer and npm installed):

git clone [email protected]:iRail/hyperRail.git
cd hyperRail/
cp .env.example .env
composer install
php artisan key:generate
chmod -R 777 storage/
npm install
php -S localhost:8081 -t public/

And your development version of the hyperRail app should be running at http://localhost:8081

I agree that this workflow is way too complex for a simple application like iRail.be and we should work on a better one. All suggestions to move towards that goal are welcome!

@AdriVanHoudt
Copy link

I didn't do the env copy so maybe that was it :P, let me try again next week. I might do a pr to the readme first to make the install step clearer 😊

@Bertware
Copy link
Member

@pietercolpaert Don't forget what's installed globally on your computer already ;) Had to install some tools like compass which weren't installed globally for me yet.

@pietercolpaert
Copy link
Member

@AdriVanHoudt Thanks! Looking forward!

@Bertware the client-side script builds are included in the repository, so it’s optional to get that up and running... Yet indeed, documentation can be better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants