Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better options transfer #1

Open
targos opened this issue Nov 30, 2016 · 1 comment
Open

better options transfer #1

targos opened this issue Nov 30, 2016 · 1 comment
Assignees

Comments

@targos
Copy link
Member

targos commented Nov 30, 2016

Instead of

{
        roiMinSurface: 30,
        roiPositive: true,
        roiNegative: false,
        greyThreshold: 0.4,
        fingerprintMinSimilarity:0.7, // minimal similarity to consider the result,
        fingerprintWidth: 12,
        fingerprintHeight: 12
    }

May I suggest to handle options like the following ?

{
    roiOptions: {
        minSurface: 30,
        positive: true,
        negative: false
    },
    greyOptions: {
        threshold: 0.4
    },
    fingerprintOptions: {
        minSimilarity:0.7, // minimal similarity to consider the result,
        width: 12,
        height: 12
    }
}
@targos
Copy link
Member Author

targos commented Nov 30, 2016

that way you can just pass them as-is to the corresponding methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants