Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical spacer outside of viewport are not included #693

Open
fcollonval opened this issue Sep 25, 2023 · 2 comments
Open

Vertical spacer outside of viewport are not included #693

fcollonval opened this issue Sep 25, 2023 · 2 comments
Assignees
Labels

Comments

@fcollonval
Copy link
Collaborator

This is a follow-up of #673 seen when reusing the diff viewer in jupyterlab-git

The spacer widgets added to the editors to align the code are not added on lines outside the viewport. Hence it breaks line alignment when scrolling long diff.

@HaudinFlorence
Copy link
Contributor

@fcollonval I tried to reproduce the issue of not having the spacers added on lines outside the viewport (using the master branch) but I dont' think I can observe it as you can see it on the following gif:
nbdime_padding_viewports_issue
Maybe I missed something.

fcollonval added a commit to fcollonval/nbdime that referenced this issue Oct 10, 2023
@vidartf
Copy link
Collaborator

vidartf commented Nov 10, 2023

@fcollonval Is this still an issue? Would you mind including some reproduction steps if it is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants