Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read icon mapping from a config file (feature request) #18

Open
fauust opened this issue Jan 21, 2019 · 1 comment
Open

Read icon mapping from a config file (feature request) #18

fauust opened this issue Jan 21, 2019 · 1 comment

Comments

@fauust
Copy link

fauust commented Jan 21, 2019

Hi,
this is not an issue but a feature request.

Would it be possible to make the script read from a file for the icon mapping? This way it would be easier to test future new versions of the script without having to edit it.

I have no time to propose a pull request for this feature but maybe in the next weeks I will.

BTW thanks for this excellent script.
Regards,
faust

@justbuchanan
Copy link
Owner

Sounds like a good idea to me. The icon list has gotten fairly long now, so it would be nice to separate it from the code. Feel free to send a PR if you get around to it.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants