Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove webhook builder when controller-runtime allows overriding a mutation handler #3137

Closed
alculquicondor opened this issue Sep 25, 2024 · 4 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@alculquicondor
Copy link
Contributor

alculquicondor commented Sep 25, 2024

What would you like to be cleaned:

Remove pkg/controller/jobframework/webhook/builder.go when kubernetes-sigs/controller-runtime#2932 is merged and released.

Why is this needed:

We duplicated the file to be able to provide a fix in Kueue faster in #3132

@alculquicondor alculquicondor added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 25, 2024
@alculquicondor
Copy link
Contributor Author

Do not assign this issue yet, because #3132 is not merged yet.

@mimowo
Copy link
Contributor

mimowo commented Nov 6, 2024

Closing in favor of #3469, as with the controller-runtime fix we can drop also our defaulter altogether.

@mimowo
Copy link
Contributor

mimowo commented Nov 6, 2024

/close

@k8s-ci-robot
Copy link
Contributor

@mimowo: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

3 participants