Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Requeued condition, and unset QuotaReserved condition on eviction in Workload Reconciler #3474

Open
PBundyra opened this issue Nov 6, 2024 · 3 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@PBundyra
Copy link
Contributor

PBundyra commented Nov 6, 2024

What would you like to be cleaned:
Currently the Requeued, and QuotaReserved conditions are set by the jobframework reconciler

Ideally this logic should be moved to the Workload Controller to simplify logic, ease maintenance and adding new features, and avoid unpredictable race conditions. The logic should be atomic with eviction

Why is this needed:

@PBundyra PBundyra added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 6, 2024
@PBundyra
Copy link
Contributor Author

PBundyra commented Nov 6, 2024

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 6, 2024
@mimowo
Copy link
Contributor

mimowo commented Nov 6, 2024

I agree it would be cleaner, but for that we need to figure out how solve the dependency issue on the Job, as currently workload controller is Job-agnostic:

if !job.IsActive() {

@tenzen-y
Copy link
Member

tenzen-y commented Nov 6, 2024

As far as I know, during introducing this mechanism, we evaluated this proposed solution. But, we declined that based on the Michal mentioned reason. I guess that we need to introduce another mechanism or a lot of refactoring...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants