Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding InstanceGroupController does not remove nodes from instance group after adding node.kubernetes.io/exclude-from-external-load-balancers label #2724

Open
VitusAcabado opened this issue Oct 31, 2024 · 1 comment

Comments

@VitusAcabado
Copy link

VitusAcabado commented Oct 31, 2024

I am running ingress-gce on a self-managed kubernetes cluster on GCE.

Adding the label node.kubernetes.io/exclude-from-external-load-balancers=true to a node that is already in an instance group does not get removed because of this line. This is observed if the instance group only has 1 node.

Since the list of nodes passed in the sync function already has the excluded nodes via CandidateNodeFilter here.

It never get processed in the for loop and these lines wont get executed.

This is observed for tags v1.30.3 onwards.

@swetharepakula
Copy link
Member

cc/ @mmamczur

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants