From 390408228723fcb9ac9e87445e955afd0dc471b5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hanno=20J=2E=20G=C3=B6decke?= Date: Sun, 5 May 2024 13:57:39 +0200 Subject: [PATCH 1/4] chore(ci): fix ios builds --- .github/workflows/ci.yml | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 767356b..bf9f5b3 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -141,6 +141,19 @@ jobs: run: pwd && bundle exec pod install working-directory: ./package/example/ios + - name: Install xcpretty + run: gem install xcpretty + working-directory: ./package/example + - name: Build iOS - run: yes | npx react-native build-ios --mode Debug working-directory: ./package/example + run: "set -o pipefail && xcodebuild \ + CC=clang CPLUSPLUS=clang++ LD=clang LDPLUSPLUS=clang++ \ + -derivedDataPath build -UseModernBuildSystem=YES \ + -workspace SkiaSkottieExample.xcworkspace \ + -scheme SkiaSkottieExample \ + -sdk iphonesimulator \ + -configuration Debug \ + -destination 'platform=iOS Simulator,name=iPhone 11 Pro' \ + build \ + CODE_SIGNING_ALLOWED=NO | xcpretty" From 2bda842c4c334e12055872486ab2960666c52316 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hanno=20J=2E=20G=C3=B6decke?= Date: Sun, 5 May 2024 14:02:36 +0200 Subject: [PATCH 2/4] specify correct path --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index bf9f5b3..5c5d93e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -146,7 +146,7 @@ jobs: working-directory: ./package/example - name: Build iOS - working-directory: ./package/example + working-directory: ./package/example/ios run: "set -o pipefail && xcodebuild \ CC=clang CPLUSPLUS=clang++ LD=clang LDPLUSPLUS=clang++ \ -derivedDataPath build -UseModernBuildSystem=YES \ From b159d52ccc125138bf2ea3e3ef5c2d65e01d1889 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hanno=20J=2E=20G=C3=B6decke?= Date: Sun, 5 May 2024 14:03:16 +0200 Subject: [PATCH 3/4] restore pods cache --- .github/workflows/ci.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5c5d93e..9a8fec2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -137,6 +137,14 @@ jobs: bundler-cache: true working-directory: ./package/example + - name: Restore Pods cache + uses: actions/cache@v4 + with: + path: ./package/example/ios/Pods + key: ${{ runner.os }}-pods-${{ hashFiles('**/Podfile.lock') }} + restore-keys: | + ${{ runner.os }}-pods- + - name: Pod install run: pwd && bundle exec pod install working-directory: ./package/example/ios From 11d24d98afd005ed9a4c305f21e9cab240106f87 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hanno=20J=2E=20G=C3=B6decke?= Date: Sun, 5 May 2024 14:09:50 +0200 Subject: [PATCH 4/4] use recent iphone model --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9a8fec2..abe79a0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -162,6 +162,6 @@ jobs: -scheme SkiaSkottieExample \ -sdk iphonesimulator \ -configuration Debug \ - -destination 'platform=iOS Simulator,name=iPhone 11 Pro' \ + -destination 'platform=iOS Simulator,name=iPhone 15 Pro Max' \ build \ CODE_SIGNING_ALLOWED=NO | xcpretty"