Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swarm select next speaker should be using the latest handoff message and check for the last speaker #4180

Closed
ekzhu opened this issue Nov 14, 2024 · 0 comments · Fixed by #4198
Assignees
Milestone

Comments

@ekzhu
Copy link
Collaborator

ekzhu commented Nov 14, 2024

I believe you just identified a bug in Swarm. Rather than using the last message to identify the handoff target, we should be using the last handoff message and check if the handoff has happened already. The currently implementation didn't consider this scenario.

Originally posted by @ekzhu in #4146 (comment)

@ekzhu ekzhu added this to the 0.4.0 milestone Nov 14, 2024
@ekzhu ekzhu self-assigned this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant