Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix Many Items in Autocomplete #1978

Open
MarvinKlein1508 opened this issue Apr 30, 2024 · 14 comments
Open

docs: fix Many Items in Autocomplete #1978

MarvinKlein1508 opened this issue Apr 30, 2024 · 14 comments
Assignees
Labels
status:blocked Any issue blocked by another

Comments

@MarvinKlein1508
Copy link
Contributor

This seems to be broken:
https://www.fluentui-blazor.net/Autocomplete
grafik

@microsoft-github-policy-service microsoft-github-policy-service bot added the triage New issue. Needs to be looked at label Apr 30, 2024
@dvoituron
Copy link
Collaborator

Not really ;-)

image

@vnbaaij vnbaaij added closed:not-actionable There is no action to be taken in response to this issue. and removed triage New issue. Needs to be looked at labels Apr 30, 2024
@vnbaaij
Copy link
Collaborator

vnbaaij commented Apr 30, 2024

Closed as not reproducible

@vnbaaij vnbaaij closed this as not planned Won't fix, can't repro, duplicate, stale Apr 30, 2024
@MarvinKlein1508
Copy link
Contributor Author

@vnbaaij I've checked again. It works in Edge for me but not in Firefox

@vnbaaij
Copy link
Collaborator

vnbaaij commented Apr 30, 2024

Re-opening. Please mention those kind of details next time. Helps triaging.

@vnbaaij vnbaaij reopened this Apr 30, 2024
@vnbaaij vnbaaij removed the closed:not-actionable There is no action to be taken in response to this issue. label Apr 30, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the triage New issue. Needs to be looked at label Apr 30, 2024
@vnbaaij vnbaaij assigned vnbaaij and dvoituron and unassigned vnbaaij Apr 30, 2024
@vnbaaij vnbaaij added bug A bug status:needs-investigation Needs additional investigation and removed triage New issue. Needs to be looked at labels May 1, 2024
@dvoituron
Copy link
Collaborator

This is due to Virtualize="true", but at the moment I don't know why it's OK with Edge but not with Firefox.

@joriverm
Copy link
Contributor

joriverm commented May 2, 2024

@dvoituron : just gave this a go in firefox as it is my main browser. im getting a warning in the console when loading the page, saying it can't load a script :
Loading failed for the <script> with source “https://www.clarity.ms/tag/hnr14wvzj8”. [Autocomplete:1:1](https://www.fluentui-blazor.net/Autocomplete). maybe related?
nvm, has to do with the firefox setting to stop content tracking

if not, i took a look at the DOM and it appears that the popup isn't getting filled in with fluent-option elements
image

@dvoituron
Copy link
Collaborator

Yep. Clarity is not linked to this problem.

I've seen that the "virtualization" part (this DOM) isn't filled in with Firefox. But I don't know why at the moment.

@dvoituron
Copy link
Collaborator

@martinbu Any idea why this problem only occurs with Firefox?

@martinbu
Copy link
Contributor

martinbu commented May 3, 2024

I have seen the issue yesterday and did a quick debugging session but could not identify the the root cause yet.
What I have seen is that the LoadFilteredItemsAsync is called but always had a Count of zero in ItemsProviderRequest. Therefore, no options are returned... It seems that the Virtualize component calculates (OnBeforeSpaceVisible and OnAfterSpacerVisible) that there is no space to render the content. When setting the breakpoint during a debugging session at the correct point, the options also appear. Therefore, I think it is a timing issue. So in chromium based browsers the area to render the list is present before the space calculation. In Firefox the calculation is done before the "area to render" is available.

But that is currently a vague assumption. I haven't had time to look at it in detail yet.

@hevilhuy
Copy link

image
Reproduced with the latest FireFox

@dvoituron
Copy link
Collaborator

Maybe related to this issue? dotnet/aspnetcore#44357

@vnbaaij
Copy link
Collaborator

vnbaaij commented Sep 25, 2024

This is still an issue in the latest Firefox version. With the problem being a timing issue in the Virtualize component, this is not something that can be solved from our side, I think.

@joriverm
Copy link
Contributor

joriverm commented Sep 26, 2024

tested this on 130.0.1, and the issue is still there
image

however, something funny/odd happened that i dont know if its related to the issue. when i added a delay (100ms) it showed the popup nicely... but the options are still gone haha
image

EDIT: if its in the base virtualize component then i agree, this might be for another team to fix

@dhazel
Copy link

dhazel commented Oct 2, 2024

Interestingly, I am seeing a very similar issue in Chrome/Edge after upgrading FluentUI from 4.10.0 to 4.10.1. The issue occurs when populating the dropdown via an async call. I will look into creating a new issue report because this thread here appears to be Firefox specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:blocked Any issue blocked by another
Projects
None yet
Development

No branches or pull requests

7 participants