Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KIOTA_CONFIG_PREVIEW shouldn't be needed anymore #5625

Open
maisarissi opened this issue Oct 17, 2024 · 1 comment
Open

KIOTA_CONFIG_PREVIEW shouldn't be needed anymore #5625

maisarissi opened this issue Oct 17, 2024 · 1 comment
Labels
enhancement New feature or request generator Issues or improvements relater to generation capabilities. type:breaking-change An issue that will result in dependent client projects failing. type:enhancement Enhancement request targeting an existing experience
Milestone
Kiota v2.0

Comments

@maisarissi
Copy link
Contributor

maisarissi commented Oct 17, 2024 •
edited by petrhollayms
Loading

The workspace.json feature was hide behind a env variable KIOTA_CONFIG_PREVIEW

Even for the new version, like 1.19.1 (release) and 1.20 (preview), if one doesn't set KIOTA_CONFIG_PREVIEW, none of the workspace features are available, including all kiota client ... , kiota plugin ... and workspace commands.

Setting the env variable shouldn't be needed anymore and everyone in the newest version should get the new experience by default.
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Oct 17, 2024
@sebastienlevert
Copy link
Contributor

Partly true. This means that we would be breaking people. We can't do that. This will require a major bump of the library...

@sebastienlevert sebastienlevert added this to the Kiota v2.0 milestone Oct 17, 2024
@baywet baywet added enhancement New feature or request generator Issues or improvements relater to generation capabilities. type:enhancement Enhancement request targeting an existing experience type:breaking-change An issue that will result in dependent client projects failing. labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request generator Issues or improvements relater to generation capabilities. type:breaking-change An issue that will result in dependent client projects failing. type:enhancement Enhancement request targeting an existing experience
Projects
Kiota
Status: Needs Triage 🔍
Milestone
Kiota v2.0
Development

No branches or pull requests
3 participants
@sebastienlevert @baywet @maisarissi