Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate vscode extension + test infrastructure to ESM #5752

Open
fey101 opened this issue Nov 11, 2024 · 1 comment
Open

Migrate vscode extension + test infrastructure to ESM #5752

fey101 opened this issue Nov 11, 2024 · 1 comment
Labels
type:feature New experience request vscode-extension Work related to the vscode-extension
Milestone

Comments

@fey101
Copy link
Contributor

fey101 commented Nov 11, 2024

Is your feature request related to a problem? Please describe the problem.

No response

Client library/SDK language

TypeScript

Describe the solution you'd like

Current infrastructure for vscode extension is based off commonjs as appears here https://github.com/microsoft/kiota/blob/main/vscode/microsoft-kiota/tsconfig.json#L4. We would like to experiment with moving the project to using ESM modules instead.

This was brought about as a result of a PR review as appears in this comment #5540 (comment)

Additional context

No response

@fey101 fey101 added status:waiting-for-triage An issue that is yet to be reviewed or assigned type:feature New experience request labels Nov 11, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Nov 11, 2024
@msgraph-bot msgraph-bot bot added the TypeScript Pull requests that update Javascript code label Nov 11, 2024
@baywet baywet moved this from Needs Triage 🔍 to Todo 📃 in Kiota Nov 11, 2024
@baywet
Copy link
Member

baywet commented Nov 11, 2024

As additional information for other readers, migrating to ESM will ensure better compatibility with upcoming updated packages, or additional packages we might want to add. It'll also guarantee better reliability as mixing package types is a common source of breakages. It might also reduce javascript size and improve loading performance.

@baywet baywet added vscode-extension Work related to the vscode-extension and removed TypeScript Pull requests that update Javascript code status:waiting-for-triage An issue that is yet to be reviewed or assigned labels Nov 11, 2024
@baywet baywet modified the milestones: Kiota v1.21, Kiota v1.22 Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New experience request vscode-extension Work related to the vscode-extension
Projects
Status: Todo 📃
Development

No branches or pull requests

2 participants