Updater can remove vscode without installing a newer version

[timholy]

Does this issue occur when all extensions are disabled?: Unknown, but presumably yes

• VS Code Version: f1a4fb1 is the new one that most recently got installed
• OS Version: WSL

The issue is that the updater deletes the old version of vscode before downloading the new one. The order should be reversed, in case the next attempted use of vscode occurs while the user is in transit or otherwise disconnected from internet.

Steps to Reproduce:

1. Wait for a new release
2. When you notice a vscode window briefly pop up, wait for that to close again and then disconnect from the internet
3. Try to launch vscode

This can be a major issue for people who travel a lot. Wifi is fairly common on planes but it is still not ubiquitous, and there are many circumstances where accessing the internet may be awkward or impossible.

[vs-code-engineering]

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.95.3. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!