Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execaを8.0.1->9.5.1にするとdevモード終了時にnodeプロセスが殺されなくなる #14966

Open
1 task
syuilo opened this issue Nov 15, 2024 · 7 comments
Labels
⚠️bug? This might be a bug

Comments

@syuilo
Copy link
Member

syuilo commented Nov 15, 2024

💡 Summary

殺したい

🥰 Expected Behavior

殺される

🤬 Actual Behavior

殺されない

📝 Steps to Reproduce

No response

💻 Frontend Environment

* Model and OS of the device(s):
* Browser:
* Server URL:
* Misskey:

🛰 Backend Environment (for server admin)

* Installation Method or Hosting Service:
* Misskey:
* Node:
* PostgreSQL:
* Redis:
* OS and Architecture:

Do you want to address this bug yourself?

  • Yes, I will patch the bug myself and send a pull request
@syuilo syuilo added the ⚠️bug? This might be a bug label Nov 15, 2024
syuilo added a commit that referenced this issue Nov 15, 2024
@syuilo
Copy link
Member Author

syuilo commented Nov 15, 2024

いやnodemon関係ない可能性が出てきた

@syuilo syuilo changed the title nodemonを3.0.2 -> 3.1.7にするとdevモード終了時にnodeプロセスが殺されなくなる devモード終了時にnodeプロセスが殺されなi Nov 15, 2024
@syuilo syuilo changed the title devモード終了時にnodeプロセスが殺されなi devモード終了時にnodeプロセスが殺されない Nov 15, 2024
@syuilo
Copy link
Member Author

syuilo commented Nov 15, 2024

execaが原因の可能性がある

@fruitriin
Copy link
Contributor

fruitriin commented Nov 15, 2024

稀にしか起きないならMisskeyのバグではないと思う
私は手元で死なないnodeプロセスがでたらよくkill -9 で殺してる

@syuilo
Copy link
Member Author

syuilo commented Nov 15, 2024

execaが原因で確定した

@syuilo syuilo changed the title devモード終了時にnodeプロセスが殺されない execaを8.0.1->9.5.1にするとdevモード終了時にnodeプロセスが殺されなくなる Nov 15, 2024
@syuilo
Copy link
Member Author

syuilo commented Nov 15, 2024

9.0.0のbreaking change見たけど影響しそうなものはなかった

@fruitriin
Copy link
Contributor

:igyo:

syuilo added a commit that referenced this issue Nov 15, 2024
@fruitriin
Copy link
Contributor

メジャーチェンジならチェンジログに載ってなくても壊れがちかも

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️bug? This might be a bug
Projects
None yet
Development

No branches or pull requests

2 participants