Maximum Call stack size reached on Shim-Array #241

raghuindra · 2020-06-17T19:05:06Z

Main project has dependent on collections/shim-array and one of its npm package also depends upon collections/shim-array.
And whenever in the code we imported(required) both packages, node js returning Maximum call stack size.
Same scenario is not happening with any other such inter dependency packs like mongoose, geolib, etc.

ejames17 · 2020-08-25T12:11:25Z

same here. I rolled back to v5.0.0

robross0606 · 2021-03-01T21:13:04Z

Seeing same thing here for me:

    RangeError: Maximum call stack size exceeded

      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:30:5)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)
      at Function.Object.<anonymous>.Array.from [as nativeFrom] (node_modules/collections/shim-array.js:31:22)

I could not get it to work fixed a version 5.0.0 either. Had to stop using it altogether as it interferred badly with Apollo GraphQL API. This looks to be using Monkey patching which is asking for trouble.

marchant · 2021-03-01T21:49:25Z

Committed a tentative fix on master, please try it and let me know if it fixes it.

matthiasg · 2021-03-02T09:18:05Z

Just wanted to use collections for the first time. The algorithms implemented looked decent, but to be honest, I am quite disappointed that importing e.g. collections/sorted-map would shim global objects. Not only because of the above error I just fell in as well, and going back to 5.0.0 did not help (it does not seem to support generators ?).

In general I find shimming of global objects like overwriting Array.from something to be avoided. If it absolutely has to be, it should be an opt-in feature.

I do not see a need for SortedMap for example to shim anything. As shimming seems to be deeply embedded, the risk of it breaking existing code at a fundamental and global level is just too high.

Robula · 2021-03-03T14:47:27Z

We've just hit this too on 5.1.12. Forcing the resolution to 5.0.0 has worked.

Note: We aren't using collections directly, it is a transitive dependency via another package.

EDIT: @marchant For the sake of this issue and your request, I tried your fix on master and it works. 👍

NebzHB · 2021-12-27T09:35:42Z

Dears,
I have the same problem when using collections on dependancies of homebridge-alexa (in mqtt dependancies) :
RangeError: Maximum call stack size exceeded
at Function.Array.from (/usr/local/lib/node_modules/homebridge-alexa/node_modules/collections/shim-array.js:32:22)
at Function.Array.from (/usr/local/lib/node_modules/homebridge-alexa/node_modules/collections/shim-array.js:32:22)
at Function.Array.from (/usr/local/lib/node_modules/homebridge-alexa/node_modules/collections/shim-array.js:32:22)
at Function.Array.from (/usr/local/lib/node_modules/homebridge-alexa/node_modules/collections/shim-array.js:32:22)
at Function.Array.from (/usr/local/lib/node_modules/homebridge-alexa/node_modules/collections/shim-array.js:32:22)
at Function.Array.from (/usr/local/lib/node_modules/homebridge-alexa/node_modules/collections/shim-array.js:32:22)
at Function.Array.from (/usr/local/lib/node_modules/homebridge-alexa/node_modules/collections/shim-array.js:32:22)
at Function.Array.from (/usr/local/lib/node_modules/homebridge-alexa/node_modules/collections/shim-array.js:32:22)
at Function.Array.from (/usr/local/lib/node_modules/homebridge-alexa/node_modules/collections/shim-array.js:32:22)
at Function.Array.from (/usr/local/lib/node_modules/homebridge-alexa/node_modules/collections/shim-array.js:32:22)

5.1.12 is installed but doesn't contain the if(!Array.nativeForm) condition on line 32. but even if i use it, i still have the error (on line 35)...

the error is on the return Array.nativeFrom(values, mapFn, thisArg);

NorthernMan54 · 2021-12-28T14:42:08Z

@marchant - Is it possible to get this fix pushed out as a release ?

In the homebridge community we have had numerous users of our packages impacted by this issue due to the usage of mqtt.

NebzHB · 2021-12-28T15:07:54Z

this fix doesn't fix the issue :( i've tried it

NorthernMan54 · 2021-12-28T15:11:15Z

@NebzHB - When I was testing, I applied the fix to all the plugins leveraging collections and that appeared to resolve the issue. Did you try that

NebzHB · 2021-12-28T15:13:26Z

not to all of them, i'll try

NebzHB · 2021-12-28T15:36:44Z

well... homebridge-camera-ffmpeg seems to still use it (^4.2.8) but doesn't crash here... so with only changing homebridge-alexa, it doesn't solve. but push to release anyway, we'll see ;)

redboltz · 2021-12-29T04:26:39Z

I tried to reproduce the issue using minimal code.

When I import (emulation code) version 5.1.12 once, it works fine.
https://wandbox.org/permlink/hmddUMmg9KvZGz94

However, I import version 5.1.12 twice, then infinity recursive call happens.
https://wandbox.org/permlink/bmniUnfwt8nqlrVB

If import order is 5.1.12 -> master, then it works fine.
https://wandbox.org/permlink/a6ttiL4PrB59cnN6

If import order is master -> 5.1.12, then infinity recursive call happens.
https://wandbox.org/permlink/SqR662bKByM5pou6

If import master twice, then it works fine.
https://wandbox.org/permlink/NhufBWIaU42d6aa6

NOTE: master is 85f00f8

So in order to fix the issue, all of collections library need to update.
(The first import is exception but depending on the order is dangerous)

After the current master including 85f00f8 fix would be released, and then all collections.js users would update the library, I guess that the issue would be fixed.

marchant · 2021-12-29T08:08:51Z

I just published the latest master as version 5.1.13.

See montagejs/collections#241

This solves montagejs/collections#241

NorthernMan54 · 2021-12-29T14:00:29Z

@marchant Tks very much I just updated my test environment and can no longer recreate the issue. ( I validated that npm had installed collections 5.1.13 )

@redboltz tks for the pull request against mqtt

This solves montagejs/collections#241

hthetiot mentioned this issue Aug 12, 2021

Resolve stack overflow in SortedSet.reduce and reduceRight #244

Open

NorthernMan54 mentioned this issue Dec 26, 2021

Range error on shim-array NorthernMan54/homebridge-alexa#481

Closed

dgreif mentioned this issue Dec 27, 2021

Crashes Homebridge: RangeError: Maximum call stack size exceeded homebridge-plugins/homebridge-camera-ffmpeg#1240

Closed

NorthernMan54 mentioned this issue Dec 28, 2021

RangeError: Maximum call stack size exceeded mqttjs/MQTT.js#1385

Closed

redboltz mentioned this issue Dec 29, 2021

Refined Topic Alias support. (Implement #1300) mqttjs/MQTT.js#1301

Merged

redboltz added a commit to redboltz/number-allocator that referenced this issue Dec 29, 2021

Updated collections.js to 5.1.13.

7352ba1

See montagejs/collections#241

redboltz added a commit to redboltz/MQTT.js that referenced this issue Dec 29, 2021

Updated collections.js related package version.

72cec5e

This solves montagejs/collections#241

redboltz mentioned this issue Dec 29, 2021

Updated collections.js related package version. mqttjs/MQTT.js#1386

Merged

YoDaMa pushed a commit to mqttjs/MQTT.js that referenced this issue Dec 29, 2021

fix(dependency): Updated collections.js related package version. (#1386)

df89a2e

This solves montagejs/collections#241

redboltz mentioned this issue Jan 5, 2022

Inclusion of "collections" package breaks my project unit tests mqttjs/MQTT.js#1392

Closed

ShenyuHuang pushed a commit to ShenyuHuang/MQTT.js that referenced this issue Mar 21, 2023

fix(dependency): Updated collections.js related package version. (#1386)

551772e

This solves montagejs/collections#241

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Maximum Call stack size reached on Shim-Array #241

Maximum Call stack size reached on Shim-Array #241

raghuindra commented Jun 17, 2020

ejames17 commented Aug 25, 2020 •

edited

Loading

robross0606 commented Mar 1, 2021 •

edited

Loading

marchant commented Mar 1, 2021

matthiasg commented Mar 2, 2021 •

edited

Loading

Robula commented Mar 3, 2021 •

edited

Loading

NebzHB commented Dec 27, 2021 •

edited

Loading

NorthernMan54 commented Dec 28, 2021

NebzHB commented Dec 28, 2021

NorthernMan54 commented Dec 28, 2021

NebzHB commented Dec 28, 2021

NebzHB commented Dec 28, 2021

redboltz commented Dec 29, 2021 •

edited

Loading

marchant commented Dec 29, 2021

NorthernMan54 commented Dec 29, 2021

Maximum Call stack size reached on Shim-Array #241

Maximum Call stack size reached on Shim-Array #241

Comments

raghuindra commented Jun 17, 2020

ejames17 commented Aug 25, 2020 • edited Loading

robross0606 commented Mar 1, 2021 • edited Loading

marchant commented Mar 1, 2021

matthiasg commented Mar 2, 2021 • edited Loading

Robula commented Mar 3, 2021 • edited Loading

NebzHB commented Dec 27, 2021 • edited Loading

NorthernMan54 commented Dec 28, 2021

NebzHB commented Dec 28, 2021

NorthernMan54 commented Dec 28, 2021

NebzHB commented Dec 28, 2021

NebzHB commented Dec 28, 2021

redboltz commented Dec 29, 2021 • edited Loading

marchant commented Dec 29, 2021

NorthernMan54 commented Dec 29, 2021

ejames17 commented Aug 25, 2020 •

edited

Loading

robross0606 commented Mar 1, 2021 •

edited

Loading

matthiasg commented Mar 2, 2021 •

edited

Loading

Robula commented Mar 3, 2021 •

edited

Loading

NebzHB commented Dec 27, 2021 •

edited

Loading

redboltz commented Dec 29, 2021 •

edited

Loading