Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to instanciate Azure Storage Client via connection string #7

Open
cmaneu opened this issue Aug 14, 2019 · 5 comments
Open

Comments

@cmaneu
Copy link

cmaneu commented Aug 14, 2019

I'm submitting a...


[ ] Regression 
[ ] Bug report
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

This lib only supports storage account name and storage account SAS Key, either through configuration, or through additional storage options in the interceptor declaration.

Expected behavior

We should be able to precise either an account name/storage account pair OR a connection string.

Minimal reproduction of the problem with instructions

Irrelevant :)

What is the motivation / use case for changing the behavior?

Having a connection string support will enable the following scenarios :

  • Support for Local Azure Storage Emulator (a must-do for developers)
  • Support for other storage emulators, like Azurite, used in integration testing via CD/CI pipelines
  • Support for non-global+public Azure Instance (Azure Gov, Azure Germany, Azure China, ...)

Environment


Nest version: 6.6.4

 
For Tooling issues:
- Node version: 10.16.1  
- Platform: Linux  

Others:

@cmaneu
Copy link
Author

cmaneu commented Aug 14, 2019

There is a few things to change in the code. For example in line azure-storage.service.ts:58 the core Azure Storage URI is embedded in the code. However, for local emulator there is no DNS resolution. Account name ends up being part of the URI (https://localhost:10000/<accountName>/<containerName>/....).

@wiekonek
Copy link

wiekonek commented Nov 2, 2020

Is there any progress on this feature request? Library is basically unusable, when we can not connect dev environment to local emulator.

@manekinekko
Copy link
Collaborator

We are working on this @wiekonek. I will keep you posted.

manekinekko added a commit that referenced this issue Nov 9, 2020
manekinekko added a commit that referenced this issue Nov 9, 2020
manekinekko added a commit that referenced this issue Nov 9, 2020
manekinekko added a commit that referenced this issue Nov 9, 2020
- NestJS 7 support
- Upgrade Azure blob storage
- Add support for connection string access

Closes #7 #129 #127
@markusheinemann
Copy link

How are you doing with the upgrades? If you need any help, please let me know :)

@manekinekko manekinekko unpinned this issue Jun 8, 2021
@SweetpopcornSimon
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants