Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Logging option #57

Open
cyberndj opened this issue Aug 10, 2022 · 2 comments
Open

[Feature]: Logging option #57

cyberndj opened this issue Aug 10, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@cyberndj
Copy link

NetBox version

v3.2.7

Feature type

Add a function

Proposed functionality

Include Logging option/selection for specific ACL entries. Add a menu option for each rule if logging is needed and what type of logging is required. ie "log" vs "log-input"

Use case

Some rules need logging on them so the logged info can be sent to external systems for processing (ie. a SIEM tool). Having the info on including the log attribute to the rule would aid in getting more complete info about an ACL.

External dependencies

none

@cyberndj cyberndj added the enhancement New feature or request label Aug 10, 2022
@ryanmerolle ryanmerolle added the good first issue Good for newcomers label Jan 21, 2023
@ryanmerolle
Copy link
Collaborator

Great idea, I totally forgot about this.
I apologize for the long delay!

It feels like this should be an optional attribute since not all platforms require this.

Since this is optional, maybe one attribute that includes the options:

  • None/default
  • log
  • log-input

@cyberndj Let me know what you think, and we can add to the model, ui, and api.

If you wanted to take a stab at it, its a good fist PR for someone not requiring a ton of python or django knowledge.

@ryanmerolle ryanmerolle self-assigned this Jan 21, 2023
@cyberndj
Copy link
Author

Hey @ryanmerolle That sounds good as you put it. When its added, I'll test it out in my 3.4 instance.

Thanks!
-Jake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants