Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how can fix this fullscreen button in iframe type and some iframe options when necessary ? #200

Open
wwwbarnamehadotnet opened this issue May 15, 2024 · 2 comments

Comments

@wwwbarnamehadotnet
Copy link

wwwbarnamehadotnet commented May 15, 2024

i have a sample html with these codes :

<html>
<head>
<style>
.h_iframe-aparat_embed_frame{position:relative;}.h_iframe-aparat_embed_frame .ratio{display:block;width:100%;height:auto;}.h_iframe-aparat_embed_frame iframe{position:absolute;top:0;left:0;width:100%;height:100%;}
</style>
</head>
<body>
<div class="h_iframe-aparat_embed_frame">
<span style="display: block;padding-top: 57%">
</span>
<iframe src="https://www.aparat.com/video/video/embed/videohash/VhbaT/vt/frame?autoplay=true" allow="autoplay" allowFullScreen="true" webkitallowfullscreen="true" mozallowfullscreen="true">
</iframe>
</div>
</body>
</html>

its work nice,all options work good (fullscreen,shortkeys,pictureinpicture, etc) and testes on chrome edge and etc
now i wana use this iframe using by venobox so i just used like as this :

<img class="my-link" data-gall="videoGallery" data-vbtype="iframe" data-href="https://www.aparat.com/video/video/embed/videohash/VhbaT/vt/frame" src="img/icons/videoplaybutton.svg" alt="customalt" width="65px" height="65px" title="custom title">

    new VenoBox({
    selector: '.my-link',
    autoplay:false,
    numeration: true,
    infinigall: true,
    share: false,
    overlayColor :'#320C58',
    spinner: 'fold',
    transitionSpeed : 400,
    toolsColor:'#ECD0E5',
      });

now my problem is about fullscreen button not worked on any browsers and some other options like as pictureinpicture or etc not activate or not enabled :

i changed allowfullscreen options in venubox.js like as these :

allowfullscreen allow="fullscreen" allowFullScreen="allowFullScreen" allowfullscreen="allowfullscreen" allowfullscreen="true" webkitallowfullscreen="true" mozallowfullscreen="true"

still not work

how can i fix this probelm?

@wwwbarnamehadotnet
Copy link
Author

?

@wwwbarnamehadotnet
Copy link
Author

temporary i solved problem with this way :

<img class="my-link" data-gall="videoGallery" data-vbtype="iframe" data-href="demo.html" src="img/icons/videoplaybutton.svg" alt="customalt" width="65px" height="65px" >

i placed codes inside a html file named demo.html with content :

    <html>
    <head>
    <style>
    .h_iframe-aparat_embed_frame{position:relative;}.h_iframe-aparat_embed_frame .ratio{display:block;width:100%;height:auto;}.h_iframe-aparat_embed_frame iframe{position:absolute;top:0;left:0;width:100%;height:100%;}
    </style>
    </head>
    <body>
    <div class="h_iframe-aparat_embed_frame">
    <span style="display: block;padding-top: 57%">
    </span>
    <iframe src="https://www.aparat.com/video/video/embed/videohash/VhbaT/vt/frame?autoplay=true" allow="autoplay" allowFullScreen="true" webkitallowfullscreen="true" mozallowfullscreen="true">
    </iframe>
    </div>
    </body>
    </html>

but that iframe has some serious issue , developer should be work for fix that issue as i guess he not follow issue any more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant