Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with space between blocks #28

Open
intelligence opened this issue Apr 19, 2023 · 1 comment
Open

Issue with space between blocks #28

intelligence opened this issue Apr 19, 2023 · 1 comment

Comments

@intelligence
Copy link

Hey!

Thanks for a great package, it's the only one I've found that can handle variable widths and heights, it's very useful for a project I'm currently working on :)

I've stumbled upon a small issue that I think relates to calculations of positions of blocks. In some instances there will be a minimal gap between blocks. See the attached video where I have purposely made all blocks green to highlight the issue. I wonder if this issue could easily be fixed by rounding off upwards for width/horizontal position to make sure that there's no gap between the blocks.

rounding.mov
@nikitaeverywhere
Copy link
Owner

Hello! Thanks for the feedback!

Quite interesting. I think rounding alone won't solve this problem, but will introduce an overlap problem then. Try playing with this line, might be round instead of floor will be a better fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants