Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programmer's colors #22

Open
defr0std opened this issue Apr 7, 2021 · 3 comments · May be fixed by #23
Open

Programmer's colors #22

defr0std opened this issue Apr 7, 2021 · 3 comments · May be fixed by #23

Comments

@defr0std
Copy link

defr0std commented Apr 7, 2021

Hi,

Do you have any plans to color more file extensions, especially for programming? .js, .ts, .cs, .h, .cpp, .json, etc.
Would you accept a contribution for such extensions?

@arcticicestudio
Copy link
Contributor

Hi @dennisfrostlander 👋, thanks for your contribution 👍

Even though there is no official specification for file extensions, the most popular and well-known ones should be added for sure 😄
The project exists for a while and does not require to be updated often so “new“ languages like TypeScript, that introduced new extensions like *.ts, are not supported yet and contributions to do so are always welcome.

While we're at it we can also add extensions for React JSX (*.jsx) as well as its TypeScript variant *.tsx and declarations (*.d.ts).

@defr0std
Copy link
Author

defr0std commented Jun 1, 2021

Should we use the 256-color scheme for the file extensions?

Those are typically specified as attr;38;5;color_number, for example like this: https://github.com/seebi/dircolors-solarized/blob/master/dircolors.256dark#L164-L194

We could choose the colors from the cheatsheet, which are closest to the Nord pallete.

@defr0std
Copy link
Author

defr0std commented Jun 2, 2021

Hmm, maybe not (about 256-color scheme). We will probably not use more than 8 distinct colors for file extensions anyway, so we can just stick to the default 8 terminal colors and then let the user customize these colors in the terminal theme itself.

@defr0std defr0std linked a pull request Jun 3, 2021 that will close this issue
rphln added a commit to rphln/Dotfiles that referenced this issue Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants