org-headline-done face

[Linuus]

The org-headline-done face needs a nice color. It's currently set to LightSalmon.

[arcticicestudio]

Hi @Linuus 👋, thanks for your contribution 👍
Added it to the backlog, but maybe someone would like to submit a PR beforehand.

[Linuus]

Would something like this work?

[arcticicestudio]

Absolutely 👍
I would have preferred nord3 for this too. This way completed items won't get in the way of the user and keeps the focus on pending items.

Feel free to submit a PR if you like so we can get this change into the theme 😄

[TRSx80]

I am not seeing org-headline-done face anywhere in source, salmon or otherwise?

What am I missing?

[TRSx80]

Hmm, now that I been playing around with some theming I noticed (by doing M-x list-faces-display) that "salmon" color is in fact (the default?) org-headline-done face (at least in there).

However, for me using (latest version, I think) of this Emacs Nord theme, none of my completed headlines appear in that salmon color, so I don't know what is going on. They just look like whatever color that they would otherwise be (when not completed). Perhaps in my case related to the issues related to starting Emacs as a daemon? (I dunno)

Having said that, I personally respectfully disagree with the "strikethrough and greyed out" method of re-formatting TODO items (especially headlines). Biggest use case / example is probably a multi-step / multi-part project, and/or with dependencies, or even when doing "weekly/periodic review" (i.e., GTD methodology) where some times you would still need to look at things that were already "DONE". I think sorting, archiving old things is another area (but can also be classified as a sort of "review".

So, given the above, perhaps consider compromise of making it user toggleable? Or maybe commented out one option or the other in source, or documented somewhere, so that others who think like I do can put it back how they like (it is Emacs, after all 😉 ).

[Linuus]

What is the value of org-fontify-done-headline? It must be t if the done headlines should be fontified.

[TRSx80]

@Linuus,

Aha! Mystery solved! 😄

I didn't even know about that variable (although it seems so obvious now)...

That also neatly wraps up my other concerns... People like me can do it how we like, and you guys same.

Cheers! 🍻

[cgoetzke]

Necro incoming!

When I installed this theme, I also found that my DONE headlines (after the keyword) were showing up salmon (nord11, I think?). This was distracting; if anything, a theme should de-emphasize DONE items, rather than draw the eye to them (though perhaps this is just personal opinion). I'm still not sure where this came from. I think the color was from the Nord palette, but the theme doesn't define the org-headline-done face. Maybe it pulled the error face (which uses nord11) because org-headline-done wasn't defined?

In any event, I added the following line to my local nord-theme.el:

`(org-headline-done ((,class (:foreground ,nord3))))

And now I have a nice subtle-yet-still-readable color on my DONE headlines.

Would there be any interest in receiving this as a PR? This seems a reasonable default for the theme to me, but others (such as @TRSx80) may prefer DONE headlines not to be de-emphasized in their workflows.