Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dark mode support #839

Open
adnjoo opened this issue Nov 8, 2023 · 2 comments
Open

feat: add dark mode support #839

adnjoo opened this issue Nov 8, 2023 · 2 comments
Labels

Comments

@adnjoo
Copy link

adnjoo commented Nov 8, 2023

can add dark mode?

@lukekarrys
Copy link
Contributor

Yes, this is a great idea! Here are the tasks I see as needed for this:

  • Add dark mode toggle to UI
  • Use primer/react auto mode to detect system dark mode
  • Save dark mode setting to local storage on change
  • Audit use of <Theme> components so theme="light" sets it back to the default

@lukekarrys lukekarrys changed the title dark mode feat: add dark mode support Nov 8, 2023
@laine-hallot
Copy link
Contributor

@lukekarrys is there a color set defined somewhere that this could be based on? I wouldn't mind making a PR for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants
@lukekarrys @laine-hallot @adnjoo and others