Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build libxkbcommon with byacc #21

Open
bluetech opened this issue Dec 9, 2020 · 1 comment
Open

Build libxkbcommon with byacc #21

bluetech opened this issue Dec 9, 2020 · 1 comment

Comments

@bluetech
Copy link

bluetech commented Dec 9, 2020

I noticed that the libxkbcommon carries a patch with a pre-generated parser.c file, because it is generated with bison. But I always did try to keep byacc working. The only detail is that byacc needs to be build with --enable-btyacc (i.e. #define YYBTYACC 1)

@michaelforney
Copy link
Collaborator

Thanks for keeping it working with byacc! Currently our byacc does not use --enable-btyacc, which is why I added the pregenerated version (we also used to use OpenBSD yacc instead of byacc). I think I am fine to enable it, but I'm a bit worried since it means the host system must have a yacc that supports %destructor. I suppose this is usually the case, except when cross-compiling from non-Linux operating systems.

At some point I might switch to using a local byacc built for the host system instead of whatever is provided by the host operating system. If I do that, then it makes sense to enable btyacc and drop the pregenerated version at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants