Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the image we build in the GitHub Action #710

Open
alexellis opened this issue Nov 11, 2020 · 3 comments
Open

Test the image we build in the GitHub Action #710

alexellis opened this issue Nov 11, 2020 · 3 comments

Comments

@alexellis
Copy link
Member

Test the image we build in the GitHub Action

Expected Behaviour

As we run e2e tests upon commit, this should test the operator image that we've just built.

Current Behaviour

Instead we test whatever is in the chart, which probably still needs to be tested separately for each chart change.

Possible Solution

Side-load the image with kind as per https://github.com/alexellis/registry-creds/blob/master/.github/workflows/ci-only.yaml

Add a new job that only tests the chart.

@matzhaugen
Copy link
Contributor

I made a drafty PR that tests the image in the PR, and hopefully solves this issue.

I also added a load testing script in the build just to show how you can replicate a scenario which gives some 404s as discussed in a separate issue. I added in this PR and CI to show the reproducibility steps.

@alexellis
Copy link
Member Author

/add label: help wanted

@derek derek bot added the help wanted label Jun 23, 2021
@zhangwinning

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants