Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission: rust-rocket #125

Open
mustiikhalil opened this issue May 4, 2020 · 1 comment
Open

Submission: rust-rocket #125

mustiikhalil opened this issue May 4, 2020 · 1 comment

Comments

@mustiikhalil
Copy link

Hey,

Hope all of you are doing well during these times. I am trying to add the following template that I created into the store if possible. it's build on rocket.rs which is a fairly new networking framework on rust.

Best Regards.

@alexellis
Copy link
Member

Hi @mustiikhalil thanks for your interest in submitting to the store.

Please could you compare your repo with the golang-http repo? What differences do you notice?

The primary thing I notice is that there's no README or usage instructions for your template. Should be an easy fix?

Next, all the code should be in a folder named template/rust-rocker/ not in the root folder.

I also don't think your instruction to switch to a non-root user is correct, so your code will execute as root. See how we do that in the official templates and copy the approach.

In our instructions we also talk about how to reference third-party libraries (perhaps Cargo modules?) show an example of this and of a plain handler please.

Ping me when you've had a chance to address of of that.

Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants