You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While working on a PR for this repository, I noticed that running 'mvn spotless:apply' results in many tens of files being reformatted.
As it is now common practice in openhab-core and openhab-addons to keep all source files spotless compliant, I wonder if we should do the same here? => If there are no objections, I would myself be quite happy to create a PR with spotless applied.
This has been discussed in the past and I'm personally not keen as it looses a lot of history and IIRC from previous discussions, also changes the XML files which will be changed back with the next update.
Ok, maybe I remembered that incorrectly, or possibly an exception was added to avoid changes. In any case the main point was I’d prefer not to loose the history and just do the updates as the files are touched rather than in one large reformat.
While working on a PR for this repository, I noticed that running 'mvn spotless:apply' results in many tens of files being reformatted.
As it is now common practice in openhab-core and openhab-addons to keep all source files spotless compliant, I wonder if we should do the same here? => If there are no objections, I would myself be quite happy to create a PR with spotless applied.
Signed-off-by: Andrew Fiddian-Green [email protected]
The text was updated successfully, but these errors were encountered: