Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shall we run mvn spotless:apply ?? #1909

Open
andrewfg opened this issue Dec 26, 2023 · 3 comments
Open

Shall we run mvn spotless:apply ?? #1909

andrewfg opened this issue Dec 26, 2023 · 3 comments

Comments

@andrewfg
Copy link
Contributor

While working on a PR for this repository, I noticed that running 'mvn spotless:apply' results in many tens of files being reformatted.

As it is now common practice in openhab-core and openhab-addons to keep all source files spotless compliant, I wonder if we should do the same here? => If there are no objections, I would myself be quite happy to create a PR with spotless applied.

Signed-off-by: Andrew Fiddian-Green [email protected]

@cdjackson
Copy link
Collaborator

This has been discussed in the past and I'm personally not keen as it looses a lot of history and IIRC from previous discussions, also changes the XML files which will be changed back with the next update.

@andrewfg
Copy link
Contributor Author

changes the XML files which will be changed back with the next update.

From memory, it seemed to me that most of the format corrections were applied to java files and not xml files. Or??

@cdjackson
Copy link
Collaborator

cdjackson commented Dec 27, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants