Server capabilities should depend on client capabilities.

[danixeee]

The goal is to refactor current implementation of how server capabilities are calculated.
Client capabilities (InitializeRequest) should be considered when creating server capabilities.

https://github.com/openlawlibrary/pygls/blob/master/pygls/types.py#L879

[tombh]

Is this still relevant now that v1 is released? Because all types live in lsprotocol, do it fix the issue or if not, could it?

[alcarney]

It's potentially relevant, while lsprotocol provides all the types now it's still on pygls to correctly fill out an instance of ServerCapabilities as this tells the client which methods etc a server supports.

While the ServerCapabilitiesBuilder does look at some client capabilities, I don't know if it does in all cases etc.

[alcarney]

Oh! and we also need to make sure we support any additional fields that were added to the spec since this was last looked at

[tombh]

Ok great, I'll look into fixing this soon then.