-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frame Core] Construct Runtime V2 follow-ups #3688
Comments
Step in #3688 Now that the `runtime` macro (Construct Runtime V2) has been successfully deployed on Westend, this PR moves it out of the experimental feature flag and makes it generally available for runtime devs. --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Kian Paimani <[email protected]>
Step in paritytech#3688 Now that the `runtime` macro (Construct Runtime V2) has been successfully deployed on Westend, this PR moves it out of the experimental feature flag and makes it generally available for runtime devs. --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Kian Paimani <[email protected]>
I am not sure about this. but it is a good candidate. Alternatively, what I see missing rn is mostly that I have also pointed out before that this macro seems to do some automatic Here's my mentality: You import #[frame::pallet]
pub mod pallet1 {
use frame::pallet_prelude::*;
}
#[frame::pallet]
pub mod pallet2 {
use frame::pallet_prelude::*;
}
#[cfg(test)]
pub mod tests {
pub use frame::testing_prelude::*;
#[frame::runtime]
pub mod runtime {
use frame::runtime_prelude::*;
}
} So the experience and behavior you would get from all of these should be as similar as possible. |
It actually maintains the same scope as with the previous CRV1. I can scope those under a
What does this |
Types that are needed for a typical runtime, the existing code should to some extent describe this polkadot-sdk/substrate/frame/src/lib.rs Lines 165 to 175 in fc07bda
|
Step in paritytech#3688 Now that the `runtime` macro (Construct Runtime V2) has been successfully deployed on Westend, this PR moves it out of the experimental feature flag and makes it generally available for runtime devs. --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Kian Paimani <[email protected]>
#1378 introduced the new runtime macro. This issue tracks the follow-up items:
experimental
flag once its tested in Rococo/Westendcfg
attrs or throw an error if they should not be used CC: @ggwpezThe text was updated successfully, but these errors were encountered: