Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tracking] remove without_storage_info for pallets migrating to AH #6289

Open
2 of 5 tasks
muharem opened this issue Oct 30, 2024 · 4 comments
Open
2 of 5 tasks

[tracking] remove without_storage_info for pallets migrating to AH #6289

muharem opened this issue Oct 30, 2024 · 4 comments

Comments

@muharem
Copy link
Contributor

muharem commented Oct 30, 2024

The pallets with #[pallet::without_storage_info] attribute or storage items with #[pallet::unbounded] attribute do not require a stored types to be bounded by the size. This simply means that those types may not implement the MaxEncodedLen trait.

The size bound required for estimation POV for a given extrinsic in advance (before executing it) and making sure a given extrinsic can fin in the a block. For the Parachains the POV estimation is mandatory and all pallets that will be setup on Asset Hub must have size bounds on the stored types, hence have no attributes like #[pallet::without_storage_info] and [pallet::unbounded].

There generally two use cases:

  1. Sized types that can derive impl of MaxEncodedLen with #[derive(MaxEncodedLen)];
  2. Unbounded type like Vec which must be migrated to BoundedVec<Member, Config::MaxMembers>.

The list of pallets with the attributes and migrating to AH:

(when you start to work on a pallet, pul your name next to it or leave a comment)

@muharem muharem added this to AHM Oct 30, 2024
@re-gius re-gius mentioned this issue Oct 31, 2024
2 tasks
@re-gius
Copy link
Contributor

re-gius commented Oct 31, 2024

claims: #6318 - merged

@re-gius re-gius moved this from Backlog to In progress in AHM Nov 4, 2024
github-merge-queue bot pushed a commit that referenced this issue Nov 4, 2024
- [x] Removing `without_storage_info` and adding bounds on the stored
types for pallet `claims` - issue
#6289
- [x] Migrating to benchmarking V2 -
#6202

---------

Co-authored-by: Guillaume Thiolliere <[email protected]>
@re-gius
Copy link
Contributor

re-gius commented Nov 4, 2024

pallet-election-provider-multi-phase: #6348 - currently waiting on another PR

@re-gius re-gius mentioned this issue Nov 5, 2024
2 tasks
@re-gius
Copy link
Contributor

re-gius commented Nov 5, 2024

pallet-society: #6367 - merged

@re-gius
Copy link
Contributor

re-gius commented Nov 11, 2024

pallet-staking: #6445 - draft, in progress

github-merge-queue bot pushed a commit that referenced this issue Nov 13, 2024
- [x] Removing `without_storage_info` and adding bounds on the stored
types for pallet `society` - issue
#6289
- [x] Migrating to benchmarking V2 -
#6202

---------

Co-authored-by: Guillaume Thiolliere <[email protected]>
Co-authored-by: Muharem <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

No branches or pull requests

2 participants