-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tracking] remove without_storage_info
for pallets migrating to AH
#6289
Comments
claims: #6318 - merged |
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 4, 2024
- [x] Removing `without_storage_info` and adding bounds on the stored types for pallet `claims` - issue #6289 - [x] Migrating to benchmarking V2 - #6202 --------- Co-authored-by: Guillaume Thiolliere <[email protected]>
pallet-election-provider-multi-phase: #6348 - currently waiting on another PR |
pallet-society: #6367 - merged |
pallet-staking: #6445 - draft, in progress |
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 13, 2024
- [x] Removing `without_storage_info` and adding bounds on the stored types for pallet `society` - issue #6289 - [x] Migrating to benchmarking V2 - #6202 --------- Co-authored-by: Guillaume Thiolliere <[email protected]> Co-authored-by: Muharem <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The pallets with
#[pallet::without_storage_info]
attribute or storage items with#[pallet::unbounded]
attribute do not require a stored types to be bounded by the size. This simply means that those types may not implement theMaxEncodedLen
trait.The size bound required for estimation POV for a given extrinsic in advance (before executing it) and making sure a given extrinsic can fin in the a block. For the Parachains the POV estimation is mandatory and all pallets that will be setup on Asset Hub must have size bounds on the stored types, hence have no attributes like
#[pallet::without_storage_info]
and[pallet::unbounded]
.There generally two use cases:
MaxEncodedLen
with#[derive(MaxEncodedLen)]
;Vec
which must be migrated toBoundedVec<Member, Config::MaxMembers>
.The list of pallets with the attributes and migrating to AH:
(when you start to work on a pallet, pul your name next to it or leave a comment)
claims
#6318election-provider-multi-phase
#6348 + Adds multi-block election types and refactors current pallets to support new interfaces and types #6034society
#6367pallet-staking
storage items #255The text was updated successfully, but these errors were encountered: