Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test: full_client::client::legacy_and_unstable_block_subscription_reconnect #1866

Open
jsdw opened this issue Nov 13, 2024 · 1 comment

Comments

@jsdw
Copy link
Collaborator

jsdw commented Nov 13, 2024

I think I've seen this test fail more than once. Can we make it more robust and remove the chance of it failing?

running 1 test
test full_client::client::legacy_and_unstable_block_subscription_reconnect has been running for over 60 seconds
test full_client::client::legacy_and_unstable_block_subscription_reconnect ... FAILED

failures:

failures:
    full_client::client::legacy_and_unstable_block_subscription_reconnect

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 85 filtered out; finished in 360.01s


--- STDERR:              integration-tests full_client::client::legacy_and_unstable_block_subscription_reconnect ---
thread 'full_client::client::legacy_and_unstable_block_subscription_reconnect' panicked at testing/integration-tests/src/full_client/client/mod.rs:415:1:
Test timedout: Elapsed(())
@jsdw
Copy link
Collaborator Author

jsdw commented Nov 13, 2024

Also the test is called legacy_and_unstable_block_subscription_reconnect but only looks like it tests the chainhead backend to me?

Running this locally it always passes in 25-30s, so maybe CI is just a bit slow and it sometimes takes a little over the default 60s timeout. PErhaps bumping it to 120s would be the quick fix, but we should think about what we're testing and maybe have a separate test for legacy and chainhead backend reconnecting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant