[BUG] Show note in file manager button doesn't respect system default

[ArkitectNaut]

Expected behaviour

Open the user's prefered file manager app (in my case Directory Opus)

Actual behaviour

Opens the windows file explorer. This behaviour is also true for the right-click method menu.

Steps to reproduce

Have different system file manager, click 'Show note in file manager' button on the toolbar. Same behaviour with right-clicking the file and selecting the 'Show note in file manager' option

[pbek]

So far, no better way to implement that on Windows crossed my path:

QOwnNotes/src/utils/misc.cpp

Lines 113 to 149 in 09a9d8a

	if (QFileInfo(path).exists()) {
	// Syntax is: explorer /select, "C:\Folder1\Folder2\file_to_select"
	// Dir separators MUST be win-style slashes
	// QProcess::startDetached() has an obscure bug. If the path has
	// no spaces and a comma(and maybe other special characters) it doesn't
	// get wrapped in quotes. So explorer.exe can't find the correct path
	// anddisplays the default one. If we wrap the path in quotes and pass
	// it to QProcess::startDetached() explorer.exe still shows the default
	// path. In this case QProcess::startDetached() probably puts its
	// own quotes around ours.
	STARTUPINFO startupInfo;
	::ZeroMemory(&startupInfo, sizeof(startupInfo));
	startupInfo.cb = sizeof(startupInfo);
	PROCESS_INFORMATION processInfo;
	::ZeroMemory(&processInfo, sizeof(processInfo));
	QString cmd = QStringLiteral("explorer.exe /select,\"%1\"")
	.arg(QDir::toNativeSeparators(absolutePath));
	LPWSTR lpCmd = new WCHAR[cmd.size() + 1];
	cmd.toWCharArray(lpCmd);
	lpCmd[cmd.size()] = 0;
	bool ret = ::CreateProcessW(NULL, lpCmd, NULL, NULL, FALSE, 0, NULL, NULL, &startupInfo,
	&processInfo);
	delete[] lpCmd;
	if (ret) {
	::CloseHandle(processInfo.hProcess);
	::CloseHandle(processInfo.hThread);
	}
	} else {
	// If the item to select doesn't exist, try to open its parent
	openPath(path.left(path.lastIndexOf("/")));
	}

Suggestions and pull requests are welcome.

[pbek]

But of course you also can write a script using a custom action and open any application with the path of the note, see https://www.qownnotes.org/scripting/methods-and-objects.html.