Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[I] Insert textlink generates wrong markdown #3159

Open
BsNoSi opened this issue Nov 15, 2024 · 6 comments
Open

[I] Insert textlink generates wrong markdown #3159

BsNoSi opened this issue Nov 15, 2024 · 6 comments

Comments

@BsNoSi
Copy link

BsNoSi commented Nov 15, 2024

Expected behaviour

Using text link creates a correct notation for hyperlink with title:

[link text](URL "link text title")

Actual behaviour

Result of this input
image
looks like this:

[link text](http://URL) link text title

Steps to reproduce

Use »insert text link« for inserting a text link


Note:

The cursor highlighting of the 'simplified operation' in Windows is always incorrectly positioned. in the editor window 'grossly incorrect':

image

I don't have another qt application for comparison. I suspect it's a bug there (so QQwnNotes ‘has to live with it’). Hence, no error message for it.

Relevant log output in the Log panel

Expand
[06:15:03] [debug] updatePanelMenu - 'updatePanelMenu'

Information about the application, settings and environment

Expand

QOwnNotes Debug Information

General Info

Current Date: Fr Nov 15 06:15:08 2024
Version: 24.11.2
Build date: Nov 13 2024
Build number: 1139
Platform: windows (windows)
Operating System: Windows 10 Version 2009
Build architecture: x86_64
Current architecture: x86_64
Release: GitHub Actions
Qt Version (build): 5.15.2
Qt Version (runtime): 5.15.2
Portable mode: no

@pbek
Copy link
Owner

pbek commented Nov 15, 2024

link text

That's not vanilla Markdown. There is no "description" in Markdown. In the case of QOwnNotes it's just some extra text you can add after the link for more clarity (like used for the "bookmark" feature).

Use »insert text link« for inserting a text link

And then?

@BsNoSi
Copy link
Author

BsNoSi commented Nov 15, 2024

🤔 Vanilla Markdown?
I use Daring Fireball / Common Mark, which is generally considered "standard definition". So I was expecting the third input field to be "title".

"title" is supported as expected here at gihub (hovering the mouse over a link will show a label as I gave in this comment).

@pbek
Copy link
Owner

pbek commented Nov 15, 2024

Daring Fireball

Ah, sorry, they even mention This is [an example](http://example.com/ "Title") inline link..
But QOwnNotes doesn't set the title, since it would only show up in a web-browser. That's why it's named Description.

image

@BsNoSi
Copy link
Author

BsNoSi commented Nov 15, 2024

💡 I understand: Description ≠ title.

A "web title" in my understanding is a "description". I use it by default because exported HTML should be accessible to disabled people using reading automation that prefers a title to reading the URL.

@pbek
Copy link
Owner

pbek commented Nov 15, 2024

Those are link titles: https://www.w3.org/TR/html401/struct/links.html#h-12.1.4

@BsNoSi
Copy link
Author

BsNoSi commented Nov 15, 2024

I know.

  • Title tags are a necessity for accessible websites (EN 301 549).
  • They support screen readers.
  • The provide predictive information, additional context for search engines and users.
  • They improve click-through rates.

That is why I add title information to my markdown, which is for me always the basis for HTML export.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants