Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InstancedAttribute could use additional types to allow shaders more options for attributes #2181

Open
Archimagus opened this issue Nov 8, 2024 · 0 comments · May be fixed by #2182
Open
Labels
enhancement New feature or request

Comments

@Archimagus
Copy link
Contributor

Archimagus commented Nov 8, 2024

I have a shader that benefits from being able to pass values as an integer rather than a float.
I would like to be able to use Drei's Instances along with its InstancedAttribute to pass the data to the shader. however InstancedAttribute only creates a Float32Array which prevents the attribute from coming across properly.

Suggested implementation:

Add an optional parameter to the InstancedAttributeProps to specify an array type.
PR: #2182

@Archimagus Archimagus added the enhancement New feature or request label Nov 8, 2024
@Archimagus Archimagus linked a pull request Nov 8, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant