Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all fields are triggered via events when the extension changes their values #19

Open
DaanBroekhof opened this issue Jan 7, 2015 · 1 comment

Comments

@DaanBroekhof
Copy link
Contributor

@paales wrote: #14 (comment)

  • There seems to be a bug that it doesn't properly save the address suffix... It seems that the CheckItOut module watches the input's for a change:
       var fields = this.content.select('input', 'select', 'textarea');
       for (var i = 0, l = fields.length; i < l; i ++) {
           if (fields[i].hasClassName('no-autosubmit')) {
               continue;
           }

           fields[i].observe('change', this.onChange);
       }

It it maybe possible to trigger this event when you change the input fields. This properly triggers the >CheckItOut module and will thus fix the second bug.

@DaanBroekhof
Copy link
Contributor Author

The issue that not all fields are 'triggered' via a javascript event when changed by our extension is something known to us, and we have a fix for that in the pipeline. We need to test it some more to prevent some unwanted side-effects (circular change event loops).

Another issue that might be happening in addition here is that the CheckItOut module creates their observe hooks on page load, when the postcode.nl extension input field have not been added to the checkout form yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant