Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing equipment creation method into VoltageLevelRawBuilder #531

Open
tadam50 opened this issue Jul 11, 2023 · 0 comments
Open

Missing equipment creation method into VoltageLevelRawBuilder #531

tadam50 opened this issue Jul 11, 2023 · 0 comments

Comments

@tadam50
Copy link
Contributor

tadam50 commented Jul 11, 2023

Describe the current behavior

As the NetworkGraphBuilder the VoltageLevelRawBuilder does not have following methods:

  • createInductor
  • createCapacitor
  • createDanglingLine
    The creation equipment method is not exhaustive.

Describe the expected behavior

The creation equipment method must be exhaustive.

Describe the motivation

Make VoltageLevelRawBuilder usage more simple.

Extra Information

Example of changes in VoltageLevelRawBuilder class:

public FeederNode createInductor(String id) {
        return createInductor(id, 0, null);
}

 public FeederNode createInductor(String id, int order, Direction direction) {
        FeederNode fn = NodeFactory.createInductor(voltageLevelGraph, id, id);
        commonFeederSetting(fn, id, order, direction);
        return fn;
 }

public FeederNode createCapacitor(String id) {
        return createCapacitor(id, 0, null);
}

public FeederNode createCapacitor(String id, int order, Direction direction) {
        FeederNode fn = NodeFactory.createCapacitor(voltageLevelGraph, id, id);
        commonFeederSetting(fn, id, order, direction);
        return fn;
}

public FeederNode createDanglingLine(String id) {
        return createCapacitor(id, 0, null);
}

public FeederNode createDanglingLine(String id, int order, Direction direction) {
        FeederNode fn = NodeFactory.createDanglingLine(voltageLevelGraph, id, id);
        commonFeederSetting(fn, id, order, direction);
        return fn;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant