Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix publish GH workflow: publish and tests should not run tests twice #126

Open
raphamorim opened this issue Jun 30, 2022 · 0 comments
Open

fix publish GH workflow: publish and tests should not run tests twice #126

raphamorim opened this issue Jun 30, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@raphamorim
Copy link
Owner

Currently the Publish workflow runs together with test, executing the same yarn ci (running tests again) it shouldn't be happening. Should wait for the test workflow check and the follow up with publish.

There's few approaches that could fix it:

  • check if the tests have passed
  • move the publish workflow to tests as a step but only runs if commit message have [publish]
@raphamorim raphamorim added the good first issue Good for newcomers label Jun 30, 2022
@raphamorim raphamorim changed the title fix publish GH workflow to run only after test check fix publish GH workflow: publish and tests should not run tests twice Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@raphamorim