-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Views rendering Views as children #67
Comments
Small update: I've got it rendering like so. it shows 1 parent view, and 2 child views. Inside each child view are three more child views. Inside those, text. Will test it some more as it ended up touching the renderer and the View element code. What isn't happening, is the container |
Hey @JohnPaulHarold , sorry for the late reply. I wasn't working on this project much last year. I have made changes on the View rendering logic lately, could check if it's still valid? |
Hello @raphamorim Sorry for the delay. I'm still seeing the same issue. Just in case I've done something silly, I did:
|
I see, thank you @JohnPaulHarold for the reply. Will try to fix it along with the #124 |
I'm seeing an oddity when rendering something like this
I'd expect to see this, more or less:
instead, it's positioning the parent
<View/>
after the children. Like thisYou can also see similar drawing setting the container to something like,
{position: 'absolute', left: 100, top: 100}
I think the issue is around here, https://github.com/raphamorim/react-ape/blob/master/packages/react-ape/renderer/elements/View.js#L52-L56
Also, it seems as though the views are rendered in order of child to parent. With that in mind, I'm not sure how you can render such a list without recomputing the child positions when you finally know the position of the parent. Although, I could be wrong. That happens often.
The text was updated successfully, but these errors were encountered: