Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r? requests should ignore zero-width spaces #1832

Open
tgross35 opened this issue Aug 16, 2024 · 4 comments
Open

r? requests should ignore zero-width spaces #1832

tgross35 opened this issue Aug 16, 2024 · 4 comments
Labels
A-assign-PR Area: PR auto assignment and welcome messages

Comments

@tgross35
Copy link
Contributor

There are some cases where it looks like Rustbot doesn't pick up review requests:

@ehuss noticed on zulip that these comments contain a zero-width space. I am not sure where this would be coming from - maybe GitHub adds them when you autocomplete an @ name - but rustbot should probably work around this.

@apiraino
Copy link
Contributor

What the GH comment contains

$ hexdump -C test.txt 
00000000  72 e2 80 8b 3f 20 40 73  63 6f 74 74 6d 63 6d 0a  |r...? @scottmcm.|
00000010

What I expect to the text to be

$ hexdump -C test1.txt 
00000000  72 3f 20 40 73 63 6f 74  74 6d 63 6d 0a           |r? @scottmcm.|

So yes that U+200B is added somehow. Tried adding a comment to a PR letting GH autocomplete my username and it looks fine.

Seems unlikely, but I wonder if these weird whitespaces are added by the user client when opening the PR.

@tgross35
Copy link
Contributor Author

I have no clue, one of those is mine and I didn't do anything out of the ordinary. Spurious GH bug?

@ehuss ehuss added the A-assign-PR Area: PR auto assignment and welcome messages label Sep 12, 2024
@apiraino
Copy link
Contributor

apiraino commented Oct 7, 2024

ok @tgross35 , the mistery is solved. Our issue github template had a bug.

Fixed by rust#131151

I saw this Zulip comment.

@jieyouxu
Copy link
Member

jieyouxu commented Oct 7, 2024

Our issue github template had a bug.

Note that this is not a bug in the PR template, this was actually a feature: it was introduced in rust-lang/rust#123492 (comment) because apparently rustbot gets confused if people didnt' remove the html comment. Possibly the better fix is to actually have rustbot/bors ignore the HTML comment too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-assign-PR Area: PR auto assignment and welcome messages
Projects
None yet
Development

No branches or pull requests

4 participants