-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r?
requests should ignore zero-width spaces
#1832
Comments
What the GH comment contains
What I expect to the text to be
So yes that U+200B is added somehow. Tried adding a comment to a PR letting GH autocomplete my username and it looks fine. Seems unlikely, but I wonder if these weird whitespaces are added by the user client when opening the PR. |
I have no clue, one of those is mine and I didn't do anything out of the ordinary. Spurious GH bug? |
ok @tgross35 , the mistery is solved. Our issue github template had a bug. Fixed by rust#131151 I saw this Zulip comment. |
Note that this is not a bug in the PR template, this was actually a feature: it was introduced in rust-lang/rust#123492 (comment) because apparently rustbot gets confused if people didnt' remove the html comment. Possibly the better fix is to actually have rustbot/bors ignore the HTML comment too. |
There are some cases where it looks like Rustbot doesn't pick up review requests:
Guard
'sdrop
method is removed atopt-level=s
for `… rust#128862@ehuss noticed on zulip that these comments contain a zero-width space. I am not sure where this would be coming from - maybe GitHub adds them when you autocomplete an
@
name - but rustbot should probably work around this.The text was updated successfully, but these errors were encountered: