Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect images in Chapter 2 #13

Open
bricef opened this issue May 28, 2016 · 2 comments
Open

Incorrect images in Chapter 2 #13

bricef opened this issue May 28, 2016 · 2 comments

Comments

@bricef
Copy link

bricef commented May 28, 2016

Problem with images

Figures 2.9 and 2.14 are incorrect and do not reflect the code in the book, or the original images.

Compare this repository's Figure 2.9 and the original.

We can see here that the limit is not interpreted in the same way, with this repo's images having more instances of the original picture than the book's images.

Compare this repository's Figure 2.14 and the original.

We can see that for example, the (right-split rogers 4) example in the book has 5 image layers, while this repository's example has 6. This is especially obvious with the corner-split examples, as the top-right corner is quite different in style.

Note on correctness

I think that this repository's images better reflect the intent of the square-limit idea. However, they do not match the code and are not a faithful representation of the original work, so should be replaced.

@bricef
Copy link
Author

bricef commented May 28, 2016

Note that I would be happy to provide high resolution bitmaps with the correct images if needed, from the wiki commons original of Rogers or the wave file if it is made available.

@sarabander
Copy link
Owner

Good observation, thanks. I corrected the code below the images (e2d0b62) as I prefer to see more layers on the picture. I'm not too concerned to remain faithful to the original in every detail.

Actually, the square-limit pictures could benefit from a redesign. It would be a good excuse to learn the Haskell Diagrams package or similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants