You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We can see here that the limit is not interpreted in the same way, with this repo's images having more instances of the original picture than the book's images.
We can see that for example, the (right-split rogers 4) example in the book has 5 image layers, while this repository's example has 6. This is especially obvious with the corner-split examples, as the top-right corner is quite different in style.
Note on correctness
I think that this repository's images better reflect the intent of the square-limit idea. However, they do not match the code and are not a faithful representation of the original work, so should be replaced.
The text was updated successfully, but these errors were encountered:
Note that I would be happy to provide high resolution bitmaps with the correct images if needed, from the wiki commons original of Rogers or the wave file if it is made available.
Good observation, thanks. I corrected the code below the images (e2d0b62) as I prefer to see more layers on the picture. I'm not too concerned to remain faithful to the original in every detail.
Actually, the square-limit pictures could benefit from a redesign. It would be a good excuse to learn the Haskell Diagrams package or similar.
Problem with images
Figures 2.9 and 2.14 are incorrect and do not reflect the code in the book, or the original images.
Compare this repository's Figure 2.9 and the original.
We can see here that the limit is not interpreted in the same way, with this repo's images having more instances of the original picture than the book's images.
Compare this repository's Figure 2.14 and the original.
We can see that for example, the
(right-split rogers 4)
example in the book has 5 image layers, while this repository's example has 6. This is especially obvious with thecorner-split
examples, as the top-right corner is quite different in style.Note on correctness
I think that this repository's images better reflect the intent of the
square-limit
idea. However, they do not match the code and are not a faithful representation of the original work, so should be replaced.The text was updated successfully, but these errors were encountered: