Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that all Sass source URLs are canonical #2297

Open
nex3 opened this issue Aug 1, 2024 · 1 comment
Open

Ensure that all Sass source URLs are canonical #2297

nex3 opened this issue Aug 1, 2024 · 1 comment
Labels
enhancement JavaScript Issues particular to the Node.js distribution
Milestone

Comments

@nex3
Copy link
Contributor

nex3 commented Aug 1, 2024

See sass/sass#3908

@nex3 nex3 added enhancement JavaScript Issues particular to the Node.js distribution labels Aug 1, 2024
@nex3 nex3 added this to the 2.0.0 milestone Aug 1, 2024
@nex3 nex3 changed the title JS: Fix SourceSpan.url Ensure that all Sass source URLs are canonical Aug 12, 2024
@nex3
Copy link
Contributor Author

nex3 commented Aug 12, 2024

Retargeting this as suggested in sass/sass#3908 (comment) to fix the loophole where the parser (and compile methods) may not canonicalize the source URLs they're passed, making it possible to have non-canonical URLs floating around. This is the root cause of non-absolute URLs showing up in the JS API.

I'm still marking this as blocked on 2.0.0, since it wreaks some havoc with the legacy JS API so we might as well wait until it's gone rather than devote a lot of effort trying to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement JavaScript Issues particular to the Node.js distribution
Projects
None yet
Development

No branches or pull requests

1 participant