Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmark #1474

Open
tigercosmos opened this issue Jun 30, 2024 · 5 comments · Fixed by #1392
Open

Update benchmark #1474

tigercosmos opened this issue Jun 30, 2024 · 5 comments · Fixed by #1392

Comments

@tigercosmos
Copy link
Collaborator

Documentation

The benchmark data is out-of-date. Should update the benchmark data with the latest versions.

https://pcapplusplus.github.io/docs/benchmark

@tigercosmos
Copy link
Collaborator Author

scapy is a well-known python library, we probably want to also add it in the benchmark.

@seladb
Copy link
Owner

seladb commented Jul 4, 2024

scapy is a well-known python library, we probably want to also add it in the benchmark.

Scapy is a Python library, I'm not sure it's "fair" to compare C++ to Python...

@seladb
Copy link
Owner

seladb commented Jul 6, 2024

@tigercosmos maybe we should move this issue to the documentation project https://github.com/PcapPlusPlus/pcapplusplus.github.io?

@tigercosmos
Copy link
Collaborator Author

I am okay. However, do we need to have multiple places to track the issues? IMO, it's easier to track the issues here.

@seladb
Copy link
Owner

seladb commented Jul 6, 2024

I'm ok with leaving it here

@egecetin egecetin linked a pull request Aug 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants