Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual Studio 17.8 build failure #1582

Open
davidbolvansky opened this issue Sep 17, 2024 · 4 comments
Open

Visual Studio 17.8 build failure #1582

davidbolvansky opened this issue Sep 17, 2024 · 4 comments
Labels
bug good first issue Windows

Comments

@davidbolvansky
Copy link

Newer Visual Studio 17.8+ C++ STL deprecates the use of checked_array_iterator with this change
microsoft/STL#3818

This causes a build error due to the deprecation if warnings are treated as errors.
@tigercosmos
Copy link
Collaborator

@davidbolvansky Thanks for the information. We will consider to make a patch for it. Feel free to submit a PR as well!

@davidbolvansky
Copy link
Author

Workaround for now:
add_compile_options(-D_SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING)

@tigercosmos
Copy link
Collaborator

Nice, but it's better to address it from the source.

@clementperon
Copy link
Collaborator

clementperon commented Oct 5, 2024 •
edited
Loading

@davidbolvansky could you point which VLA is causing the issue ?

Maybe you can open a MR and follow what has been done for FreeBSD
e5f6911

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@clementperon @tigercosmos @davidbolvansky