Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version of actionpack.rbi not compatible with Rails <= 5 #306

Open
paul-mannino opened this issue Nov 17, 2020 · 1 comment
Open

Comments

@paul-mannino
Copy link

paul-mannino commented Nov 17, 2020

ActionDispatch::Http::ParameterFilter = ActiveSupport::ParameterFilter

This line causes srb rbi update to segfault on my version of Rails (5.2). ActiveSupport::ParameterFilter was introduced in Rails 6. Happy to help but unsure what the most pragmatic fix would be. Should Rails rbi's just be major version-scoped?

@paul-mannino paul-mannino changed the title Latest version of actionpack.rbi not compatible with Rails 5 Latest version of actionpack.rbi not compatible with Rails <= 5 Nov 17, 2020
@jeffcarbs
Copy link
Contributor

The RBI for some of the other Rails gems (e.g. ActiveRecord: https://github.com/sorbet/sorbet-typed/tree/master/lib/activerecord) make use of version scoping so I think that would be appropriate to do here as well. Feel free to move that and anything else you notice into the appropriately versioned spot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants