You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This line causes srb rbi update to segfault on my version of Rails (5.2). ActiveSupport::ParameterFilter was introduced in Rails 6. Happy to help but unsure what the most pragmatic fix would be. Should Rails rbi's just be major version-scoped?
The text was updated successfully, but these errors were encountered:
paul-mannino
changed the title
Latest version of actionpack.rbi not compatible with Rails 5
Latest version of actionpack.rbi not compatible with Rails <= 5
Nov 17, 2020
The RBI for some of the other Rails gems (e.g. ActiveRecord: https://github.com/sorbet/sorbet-typed/tree/master/lib/activerecord) make use of version scoping so I think that would be appropriate to do here as well. Feel free to move that and anything else you notice into the appropriately versioned spot.
sorbet-typed/lib/actionpack/all/actionpack.rbi
Line 1373 in e2c66cd
This line causes
srb rbi update
to segfault on my version of Rails (5.2). ActiveSupport::ParameterFilter was introduced in Rails 6. Happy to help but unsure what the most pragmatic fix would be. Should Rails rbi's just be major version-scoped?The text was updated successfully, but these errors were encountered: