You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When adding the addon to an existing Storybook via npx storybook@latest add @storybook/addon-styling-webpack there are a couple of issues that may yield some confusion and inconsistencies when running Storybook with the addon enabled.
Steps to reproduce the behavior
Running npx storybook@latest add @storybook/addon-styling-webpack prompts users with a bit of a misleading message mentioning that there are some uncommitted changes in the local repository and prompts them to continue the process or not. The only actionable item being performed is the install process, which yields a change in the repository state as the required files (i.e., package.json, yarn.lock/package-lock.json and .storybook/main.js|ts) are getting updated accordingly to account for the addon installation as shown below
We'll need to tweak the wording so that it's more clear on what's happening.
Additionally, during the installation process, users are prompted to select from a list of available options to aid in the addon's configuration. However, as displayed below, the addon adds a second addon entry to Storybook's configuration file with some configuration (that can be further optimized with some linting). I'm aware that this may be a tricky item to solve, but we should address it at some time in the near future to avoid any unwanted issues that may surface due to this misconfiguration.
Describe the bug
When adding the addon to an existing Storybook via
npx storybook@latest add @storybook/addon-styling-webpack
there are a couple of issues that may yield some confusion and inconsistencies when running Storybook with the addon enabled.Steps to reproduce the behavior
Running
npx storybook@latest add @storybook/addon-styling-webpack
prompts users with a bit of a misleading message mentioning that there are some uncommitted changes in the local repository and prompts them to continue the process or not. The only actionable item being performed is the install process, which yields a change in the repository state as the required files (i.e.,package.json
,yarn.lock
/package-lock.json
and.storybook/main.js|ts
) are getting updated accordingly to account for the addon installation as shown belowWe'll need to tweak the wording so that it's more clear on what's happening.
Additionally, during the installation process, users are prompted to select from a list of available options to aid in the addon's configuration. However, as displayed below, the addon adds a second addon entry to Storybook's configuration file with some configuration (that can be further optimized with some linting). I'm aware that this may be a tricky item to solve, but we should address it at some time in the near future to avoid any unwanted issues that may surface due to this misconfiguration.
Environment
Looking forward to hearing your thoughts on this @integrayshaun
The text was updated successfully, but these errors were encountered: